[bug 1164205] Refactor search suggest api #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the search suggest API to use more DRF-y things including built-in DRF-y validation. In the process of doing this, I changed it so that you can provide the filter parameters in the querystring OR in the HTTP request body as JSON.
|
This curl stuff helps test: |
|
The Travis failure is from failing to download or not having simplejson which isn't related to these changes. It's either a spurious error or related to the master branch. |
| @@ -11,49 +12,75 @@ | |||
| from kitsune.wiki.models import DocumentMappingType | |||
|
|
|||
|
|
|||
| def positive_integer(value): | |||
There was a problem hiding this comment.
do you need to check if it's an int in the first place?
There was a problem hiding this comment.
The serializer has it as an IntegerField, so that should do the integer validation. Pretty sure one of the existing tests covers that scenario.
There was a problem hiding this comment.
Makes sense. I typed before scrolling
I have no idea if this is the format we want to go with, but it is some documentation. Maintaining it will be painful. It's probably better for us to figure out a way to autogenerate the documentation or somehow move the documentation to the code. That work is covered in bug #1164247.
|
^^^ Add some rough docs for the sumo search suggest api. |
| data = json.dumps({'q': 'emails'}) | ||
| # Note: Have to use .generic() because .get() will convert the | ||
| # data into querystring params and then it's clownshoes all | ||
| # the way down. |
|
I ran tests. Did some manual tests via browser and curl. My machine didn't catch 🔥. r+ |
rlr
added a commit
that referenced
this pull request
May 13, 2015
[bug 1164205] Refactor search suggest api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the search suggest API to use more DRF-y things including
built-in DRF-y validation.
In the process of doing this, I changed it so that you can provide the filter
parameters in the querystring OR in the HTTP request body as JSON.
r?